-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include hot fixes in dev #3010
Open
sgoggins
wants to merge
33
commits into
dev
Choose a base branch
from
main
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Include hot fixes in dev #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment out update weight task as it is no longer needed
Release 0.81.0
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
- Copy keyman directory in Dockerfile - Update graphical dockerfile to reflect the current build process Signed-off-by: Ulincsys <ulincsys@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Fix key orchestrator missing in Docker build
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
- Fix logical issue with try block - Use multiline string for logging Signed-off-by: Ulincsys <ulincsys@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Logging and logical improvements for test_connection decorator
Strip whitespace from keys while loading
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Filter worker_oauth keys by platform in cli
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Fix comparison with NoneType logical error
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Reduce dependency on create_collection_status_record tasks
|
||
|
||
def cleanup_after_collection_halt(logger, engine): | ||
def cleanup_collection_status_and_rabbit(logger, engine): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pylint] reported by reviewdog 🐶
W0621: Redefining name 'logger' from outer scope (line 34) (redefined-outer-name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description